Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixed custom emotes background color #27745 #12798

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

asimdelvi
Copy link
Contributor

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

fixes element-hq/element-web#27745

in github-markdown-css, img background is set to #fff for light theme and #000 for dark theme. So had to override the styling.

@asimdelvi asimdelvi requested a review from a team as a code owner July 19, 2024 12:34
@asimdelvi asimdelvi requested review from dbkr and t3chguy July 19, 2024 12:34
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 19, 2024
@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 19, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, could you add a comment to the style so its clear to future readers why this override exists

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024

The reason the tests are failing is due to your fork of https://github.com/asimdelvi/element-web being out of date, could you sync that up so the fork matching doesn't fail :)

@asimdelvi
Copy link
Contributor Author

yep, updated the branch.
Thanks

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2024

You checked Sign-off given on the changes but I don't see a sign off from you, that should be all that is missing to get this landed

@asimdelvi
Copy link
Contributor Author

Signed-off-by: Asim Mohammed Delvi asimdelvi30@gmail.com

@asimdelvi
Copy link
Contributor Author

thanks for the guidance @t3chguy

@t3chguy t3chguy added this pull request to the merge queue Aug 5, 2024
Merged via the queue into matrix-org:develop with commit 92bf203 Aug 5, 2024
27 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App displays a background for custom emotes when it should be transparent
2 participants