This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix broken jest tests on develop #12806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
added
the
T-Task
t3chguy
approved these changes
Jul 24, 2024
t3chguy
added
the
backport staging
RiotRobot
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit a35ab23)
|
stupid question, but how did develop come to be broken without failing CI? Is there a particular PR that broke it? |
4 tasks
|
2 of @MidhunSureshR's PRs touched similar areas and conflicted, one of them had to be force merged due to the tests needing to be skipped to make it into the release in time. The CI was not re-ran against latest develop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly from defaulting the new room header to on.