This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move rehydration of MatrixClients from MatrixClientPeg to SessionLoader #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we don't create a spurious MatrixClient which is thrown away by the SessionLoader (whilst still ensuring that the rehydrated matrixclient follows the same code path as matrixclients created at other points in the session load process).
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Aug 10, 2016
1. fix the 'Clean load' tests which had been broken by matrix-org/matrix-react-sdk#399: make sure we clear localStorage between tests. 2. Test the session rehydration properly by setting the localStorage rather than setting up the MatrixClientPeg before loading the app. 3. Add some tests for the auto-guest-registration flows.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Aug 10, 2016
This had been broken by matrix-org/matrix-react-sdk#399. Change the way we populate the matrixclient used for the joining tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that we don't create a spurious MatrixClient which is thrown away by
the SessionLoader (whilst still ensuring that the rehydrated matrixclient
follows the same code path as matrixclients created at other points in the
session load process).