This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve Keyboard Shortcuts. Add alt-arrows & alt-shift-arrows #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…x-org/matrix-react-sdk into t3chguy/shortcuts1
|
If you order rooms by unread, it's a bit surprising that as you flip through the rooms you mark them read... and so their position jumps to the read section of the list, so if you're trying to alt-up/down through the list one by one, it's a bit surprising that the list jumps around from under you. Not sure what the right solution to that is, other than possibly debouncing the jumps somehow? |
|
I believe that is what sticky room is meant to do, I disabled it in the test build as it's very very jumpy when switching successively |
…croll event Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
reviewed
Mar 20, 2020
bwindels
added
the
X-Release-Blocker
…x-org/matrix-react-sdk into t3chguy/shortcuts1
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#301
Test build: https://riots.im/adhoc/shortcuts2/
The new test build (v2) no longer disables RLS' stickyRoom so expect that failure mode until element-hq/element-web#11743 is fixed.