This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make the hangup button do things for conference calls #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behaviour constraints: * If you're not in the conference, use a grey button that does nothing. * If you're in the conference, show a button: * If you're able to modify widgets in the room, annotate it in the context of ending the call for everyone and remove the widget. Use a confirmation dialog. * If you're not able to modify widgets in the room, hang up. For this we know that persistent Jitsi widgets will mean that the user is in the call, so we use that to determine if they are actually participating.
jryans
approved these changes
Sep 17, 2020
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
niquewoodhouse
approved these changes
Sep 29, 2020
|
tests are failing due to an old branch - will monitor develop after merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design reviewer: this doesn't have an easy adhoc build, sorry - DM me for details of one though. This PR is looking for your grace to enter mainline Element.
Review with element-hq/element-web#15219
Behaviour constraints:
For this we know that persistent Jitsi widgets will mean that the user is in the call, so we use that to determine if they are actually participating.
Screenshots:
