Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wire up MSC2931 widget navigation #5527

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Wire up MSC2931 widget navigation #5527

merged 4 commits into from
Jan 18, 2021

Conversation

turt2live
Copy link
Member

Fixes element-hq/element-web#16006
Requires matrix-org/matrix-widget-api#27

Demo of it working (requested capability, navigating to a room then a permalink):

2020-12-29.12-28-42.mp4

@turt2live
Copy link
Member Author

Tests are expected to fail due to lack of branch matching with the widget-api.

@turt2live turt2live requested a review from a team December 29, 2020 19:40
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good overall, just a question on the wording.

src/widgets/CapabilityText.tsx Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from jryans January 17, 2021 06:34
turt2live added a commit to element-hq/element-web that referenced this pull request Jan 17, 2021
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on it! 😄

@turt2live turt2live merged commit 83fb698 into develop Jan 18, 2021
@turt2live turt2live deleted the travis/widget-nav branch January 18, 2021 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure out how to intercept matrix.to URLs in widgets
2 participants