Skip to content

MSC2666: Get rooms in common with another user#2666

Merged
turt2live merged 41 commits intoold_masterfrom
hs/shared-rooms
Mar 4, 2026
Merged

MSC2666: Get rooms in common with another user#2666
turt2live merged 41 commits intoold_masterfrom
hs/shared-rooms

Conversation

@Half-Shot
Copy link
Copy Markdown
Contributor

@Half-Shot Half-Shot commented Jul 5, 2020 •
edited by turt2live
Loading

Rendered

Author: @Half-Shot, @ShadowJonathan

Implementations:

Click to reveal Legacy Implementations

Spec PR note

The endpoint path was clarified in 9a49a47

SCT stuff:

FCP tickyboxes

MSC checklist

@Half-Shot Half-Shot mentioned this pull request Apr 4, 2023
Open
@Half-Shot Half-Shot changed the title MSC2664 Get rooms in common with another user MSC2666 Get rooms in common with another user Jul 5, 2020
@Half-Shot Half-Shot added the proposal A matrix spec change proposal label Jul 5, 2020
@Half-Shot Half-Shot mentioned this pull request Jul 5, 2020
Merged
Sorunome
Sorunome reviewed Jul 5, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
Comment thread proposals/2666-get-rooms-in-common.md Outdated
timokoesters
timokoesters reviewed Jul 5, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
uhoreg
uhoreg reviewed Jul 5, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
Comment thread proposals/2666-get-rooms-in-common.md Outdated
@Half-Shot @uhoreg
uhoreg fixes my spelling
5254076 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@turt2live turt2live changed the title MSC2666 Get rooms in common with another user MSC2666: Get rooms in common with another user Jul 5, 2020
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal-in-review labels Jul 5, 2020
@turt2live turt2live self-requested a review July 5, 2020 16:26
timokoesters
timokoesters reviewed Jul 6, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
Half-Shot
Half-Shot commented Jul 10, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
@Half-Shot Half-Shot mentioned this pull request Jul 10, 2020
Merged
3 tasks
uhoreg
uhoreg reviewed Jul 10, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
tulir
tulir reviewed Jul 10, 2020
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
turt2live
turt2live requested changes Jul 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this doesn't feel like it needs to be an endpoint.

Comment thread proposals/2666-get-rooms-in-common.md Outdated
anoadragon453
anoadragon453 approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This MSC and the associated Synapse implementation look good to me.

Excited to see this one land!

Comment thread proposals/2666-get-rooms-in-common.md Outdated
clokep
clokep reviewed Jan 13, 2026
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
dbkr
dbkr reviewed Jan 13, 2026
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
dbkr
dbkr reviewed Jan 13, 2026
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md
@jason-famedly jason-famedly mentioned this pull request Jan 14, 2026
Merged
@FrenchGithubUser FrenchGithubUser mentioned this pull request Jan 15, 2026
Merged
@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Feb 10, 2026
richvdh
richvdh reviewed Feb 24, 2026
View reviewed changes
Comment thread proposals/2666-get-rooms-in-common.md Outdated
Comment thread proposals/2666-get-rooms-in-common.md Outdated
tulir and others added 2 commits February 24, 2026 19:43
@tulir @anoadragon453 @dbkr
Apply suggestions from code review
66b4540 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
@tulir
Add count field
62f36cc
@tulir
Copy link
Copy Markdown
Member

tulir commented Feb 27, 2026

@mscbot resolve implementations need updating to match specified error responses

element-hq/synapse#19511

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Feb 27, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. unresolved-concerns This proposal has at least one outstanding concern labels Feb 27, 2026
@tulir tulir mentioned this pull request Feb 27, 2026
Merged
3 tasks
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Mar 3, 2026
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Mar 3, 2026
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Mar 4, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Mar 4, 2026
@turt2live turt2live merged commit 8134d6a into old_master Mar 4, 2026
@thetayloredman thetayloredman mentioned this pull request Apr 30, 2026
Open
3 tasks
@thetayloredman
Copy link
Copy Markdown

thetayloredman commented Apr 30, 2026

I thought I'd give a shot at writing this a Spec PR: matrix-org/matrix-spec#2367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikjohnston erikjohnston erikjohnston left review comments

@richvdh richvdh richvdh left review comments

@dbkr dbkr dbkr left review comments

@uhoreg uhoreg uhoreg left review comments

@clokep clokep clokep left review comments

@tulir tulir tulir approved these changes

@KitsuneRal KitsuneRal KitsuneRal left review comments

@turt2live turt2live turt2live approved these changes

@anoadragon453 anoadragon453 anoadragon453 approved these changes

+8 more reviewers

@kevincox kevincox kevincox approved these changes

@Sorunome Sorunome Sorunome left review comments

@Johennes Johennes Johennes left review comments

@timokoesters timokoesters timokoesters left review comments

@auscompgeek auscompgeek auscompgeek left review comments

@ptman ptman ptman left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

@velikopter velikopter velikopter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Half-Shot Half-Shot

Labels

client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review

Projects

Spec Core Team Workflow
Status: Requires spec PR review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.