Add /user/{user_id}/shared_rooms/ api #7785

Half-Shot · 2020-07-05T11:59:18Z

This change adds an unstable feature for fetching rooms you have in common with a user. Since synapse already implements this at the storage level, this API just exposes this as an endpoint in order to provide support for https://github.com/vector-im/riot-web/issues/14339.

MSC 2666

Leftover things to implement from the MSC

Reject user_id == other_user_id
Replace rooms with joined.

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
Code style is correct (run the linters)

Half-Shot · 2020-07-05T12:58:40Z

I seem to be having some CI challenges:

isort has jumped to isort==5.0.3, wheras a PR from two days ago in this repo was using isort==4.3.21. Attempting to fix in Explain the purpose of "async-components" for contributors element-hq/element-web#7786
~~black wants return 200, {"rooms": rooms,} and flake8 wants return 200, {"rooms": rooms, }~~ fixed

`-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020

tulir

Works fine on maunium.net

synapse/rest/__init__.py

anoadragon453 · 2020-07-10T10:56:06Z

synapse/rest/client/v2_alpha/shared_rooms.py

+    async def on_GET(self, request, user_id, other_user_id):
+        requester = await self.auth.get_user_by_req(request)
+        if user_id != requester.user.to_string():
+            raise AuthError(403, "Cannot get shared rooms for other users.")


I think this is wordly slightly unclearly. How about

Suggested change

raise AuthError(403, "Cannot get shared rooms for other users.")

raise AuthError(403, "Cannot get shared rooms between other users.")

I dunno, I think that sounds more confusing tbh. Probably need to #wordsmith it.

synapse/rest/client/v2_alpha/shared_rooms.py

richvdh · 2020-07-28T12:37:38Z

@Half-Shot, @anoadragon453 : what's the state of play here?

anoadragon453 · 2020-07-28T19:01:23Z

@richvdh matrix-org/matrix-spec-proposals#2666 seems to have stalled on the spec core team's side. I'm not sure if this PR needs updating for the current state of the MSC. Can you confirm @Half-Shot?

The MSC has unstable prefixes clearly defined, so I think this PR can go ahead as long as it adheres to those.

richvdh · 2020-07-29T12:03:33Z

ok, will label it as awaiting changes until @Half-Shot gets a chance to update it.

richvdh · 2020-07-29T12:04:05Z

(mostly: please avoid the situation where both of you are waiting for the other to make the next move)

Half-Shot · 2020-07-31T13:08:32Z

Hi, sorry for taking a bit too long here. I believe we are stalled on the spec side, but I need to double check this PR conforms to the latest v of the spec. Will do so now.

synapse/rest/__init__.py

synapse/storage/databases/main/user_directory.py

Co-authored-by: Tulir Asokan <tulir@maunium.net>

Half-Shot · 2020-08-31T15:48:22Z

Well, not sure how I have broken that test 😔

anoadragon453

Sorry, just one small thing left. Otherwise lgtm!

anoadragon453 · 2020-09-02T10:40:17Z

synapse/rest/client/v2_alpha/shared_rooms.py

+    """
+
+    PATTERNS = client_patterns(
+        "/uk.half-shot.msc2666/user/shared_rooms/(?P<user_id>[^/]*)",


Sorry, just noticed this and your MSC don't match up. You'll want to put /unstable/ before /uk.half-shot.msc2666. This matches the unstable endpoint definitions laid out in MSC2324.

You can do so by adding unstable=True to this function call (and at that point the # This is an unstable feature comment is likely redundant).

I don't need to. unstable is True by default. I don't think I need to stick /unstable/ before the path either.

Ah! My bad. Just a couple doc updates then and we're good to go!

UPGRADE.rst

synapse/storage/databases/main/user_directory.py

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Half-Shot · 2020-09-02T11:16:15Z

Ugh, this is getting so tedious.

anoadragon453

Just these then, and then lgtm! 🎉

UPGRADE.rst

docs/workers.md

unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>

anoadragon453 · 2020-09-02T11:20:45Z

Ugh, this is getting so tedious.

I know it was a lot of work - but in the end we ended up with a more efficient SQL query, tests and documentation 🙂

Half-Shot · 2020-09-02T11:22:35Z

Ugh, this is getting so tedious.

I know it was a lot of work - but in the end we ended up with a more efficient SQL query, tests and documentation slightly_smiling_face

oh I meant the CI failing. Turns out I forgot to merge. I think it's all good now 🤞

@maquis196

Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](#6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](matrix-org/matrix-spec-proposals#2666). ([\#7785](#7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](#8013), [\#8116](#8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](#8034), [\#8092](#8092), [\#8095](#8095), [\#8142](#8142), [\#8152](#8152), [\#8157](#8157), [\#8158](#8158), [\#8176](#8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](#8037), [\#8107](#8107), [\#8252](#8252)) - Add unread messages count to sync responses, as specified in [MSC2654](matrix-org/matrix-spec-proposals#2654). ([\#8059](#8059), [\#8254](#8254), [\#8270](#8270), [\#8274](#8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](#8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](#7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](#8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](#8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](#8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](#8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](#8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](#8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](#8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](#8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](#8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](#8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](#8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](#8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](#8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](#8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](#8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](#8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](#8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](#8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](#7377), [\#8163](#8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](#7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](#7991)) - Convert various parts of the codebase to async/await. ([\#8071](#8071), [\#8072](#8072), [\#8074](#8074), [\#8075](#8075), [\#8076](#8076), [\#8087](#8087), [\#8100](#8100), [\#8119](#8119), [\#8121](#8121), [\#8133](#8133), [\#8156](#8156), [\#8162](#8162), [\#8166](#8166), [\#8168](#8168), [\#8173](#8173), [\#8191](#8191), [\#8192](#8192), [\#8193](#8193), [\#8194](#8194), [\#8195](#8195), [\#8197](#8197), [\#8199](#8199), [\#8200](#8200), [\#8201](#8201), [\#8202](#8202), [\#8207](#8207), [\#8213](#8213), [\#8214](#8214)) - Remove some unused database functions. ([\#8085](#8085)) - Add type hints to various parts of the codebase. ([\#8090](#8090), [\#8127](#8127), [\#8187](#8187), [\#8241](#8241), [\#8140](#8140), [\#8183](#8183), [\#8232](#8232), [\#8235](#8235), [\#8237](#8237), [\#8244](#8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](#8093), [\#8112](#8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](#8113)) - Remove `ChainedIdGenerator`. ([\#8123](#8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](#8124)) - Update the test federation client to handle streaming responses. ([\#8130](#8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](#8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](#8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](#8164), [\#8179](#8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](#8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](#8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](#8174), [\#8181](#8181)) - Standardize the mypy configuration. ([\#8175](#8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](#8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](#8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](#8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](#8204), [\#8205](#8205), [\#8222](#8222), [\#8224](#8224), [\#8225](#8225), [\#8231](#8231), [\#8233](#8233), [\#8234](#8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](#8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](#8245)) - Stop sub-classing from object. ([\#8249](#8249)) - Add more logging to debug slow startup. ([\#8264](#8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](#8266), [\#8276](#8276))

@maquis196

Synapse 1.20.0 (2020-09-22) =========================== No significant changes since v1.20.0rc5. Removal warning --------------- Historically, the [Synapse Admin API](https://github.com/matrix-org/synapse/tree/master/docs) has been accessible under the `/_matrix/client/api/v1/admin`, `/_matrix/client/unstable/admin`, `/_matrix/client/r0/admin` and `/_synapse/admin` prefixes. In a future release, we will be dropping support for accessing Synapse's Admin API using the `/_matrix/client/*` prefixes. This makes it easier for homeserver admins to lock down external access to the Admin API endpoints. Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](matrix-org/synapse#8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](matrix-org/synapse#8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](matrix-org/synapse#8349)) Internal Changes ---------------- - Blacklist [MSC2753](matrix-org/matrix-spec-proposals#2753) SyTests until it is implemented. ([\#8285](matrix-org/synapse#8285)) Synapse 1.20.0rc4 (2020-09-16) ============================== Synapse 1.20.0rc4 is identical to 1.20.0rc3, with the addition of the security fix that was included in 1.19.2. Synapse 1.20.0rc3 (2020-09-11) ============================== Bugfixes -------- - Fix a bug introduced in v1.20.0rc1 where the wrong exception was raised when invalid JSON data is encountered. ([\#8291](matrix-org/synapse#8291)) Synapse 1.20.0rc2 (2020-09-09) ============================== Bugfixes -------- - Fix a bug introduced in v1.20.0rc1 causing some features related to notifications to misbehave following the implementation of unread counts. ([\#8280](matrix-org/synapse#8280)) Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](matrix-org/synapse#6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](matrix-org/matrix-spec-proposals#2666). ([\#7785](matrix-org/synapse#7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](matrix-org/synapse#8013), [\#8116](matrix-org/synapse#8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](matrix-org/synapse#8034), [\#8092](matrix-org/synapse#8092), [\#8095](matrix-org/synapse#8095), [\#8142](matrix-org/synapse#8142), [\#8152](matrix-org/synapse#8152), [\#8157](matrix-org/synapse#8157), [\#8158](matrix-org/synapse#8158), [\#8176](matrix-org/synapse#8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](matrix-org/synapse#8037), [\#8107](matrix-org/synapse#8107), [\#8252](matrix-org/synapse#8252)) - Add unread messages count to sync responses, as specified in [MSC2654](matrix-org/matrix-spec-proposals#2654). ([\#8059](matrix-org/synapse#8059), [\#8254](matrix-org/synapse#8254), [\#8270](matrix-org/synapse#8270), [\#8274](matrix-org/synapse#8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](matrix-org/synapse#8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](matrix-org/synapse#7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](matrix-org/synapse#8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](matrix-org/synapse#8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](matrix-org/synapse#8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](matrix-org/synapse#8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](matrix-org/synapse#8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](matrix-org/synapse#8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](matrix-org/synapse#8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](matrix-org/synapse#8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](matrix-org/synapse#8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](matrix-org/synapse#8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](matrix-org/synapse#8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](matrix-org/synapse#8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](matrix-org/synapse#8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](matrix-org/synapse#8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](matrix-org/synapse#8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](matrix-org/synapse#8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](matrix-org/synapse#8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](matrix-org/synapse#8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](matrix-org/synapse#7377), [\#8163](matrix-org/synapse#8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](matrix-org/synapse#7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](matrix-org/synapse#7991)) - Convert various parts of the codebase to async/await. ([\#8071](matrix-org/synapse#8071), [\#8072](matrix-org/synapse#8072), [\#8074](matrix-org/synapse#8074), [\#8075](matrix-org/synapse#8075), [\#8076](matrix-org/synapse#8076), [\#8087](matrix-org/synapse#8087), [\#8100](matrix-org/synapse#8100), [\#8119](matrix-org/synapse#8119), [\#8121](matrix-org/synapse#8121), [\#8133](matrix-org/synapse#8133), [\#8156](matrix-org/synapse#8156), [\#8162](matrix-org/synapse#8162), [\#8166](matrix-org/synapse#8166), [\#8168](matrix-org/synapse#8168), [\#8173](matrix-org/synapse#8173), [\#8191](matrix-org/synapse#8191), [\#8192](matrix-org/synapse#8192), [\#8193](matrix-org/synapse#8193), [\#8194](matrix-org/synapse#8194), [\#8195](matrix-org/synapse#8195), [\#8197](matrix-org/synapse#8197), [\#8199](matrix-org/synapse#8199), [\#8200](matrix-org/synapse#8200), [\#8201](matrix-org/synapse#8201), [\#8202](matrix-org/synapse#8202), [\#8207](matrix-org/synapse#8207), [\#8213](matrix-org/synapse#8213), [\#8214](matrix-org/synapse#8214)) - Remove some unused database functions. ([\#8085](matrix-org/synapse#8085)) - Add type hints to various parts of the codebase. ([\#8090](matrix-org/synapse#8090), [\#8127](matrix-org/synapse#8127), [\#8187](matrix-org/synapse#8187), [\#8241](matrix-org/synapse#8241), [\#8140](matrix-org/synapse#8140), [\#8183](matrix-org/synapse#8183), [\#8232](matrix-org/synapse#8232), [\#8235](matrix-org/synapse#8235), [\#8237](matrix-org/synapse#8237), [\#8244](matrix-org/synapse#8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](matrix-org/synapse#8093), [\#8112](matrix-org/synapse#8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](matrix-org/synapse#8113)) - Remove `ChainedIdGenerator`. ([\#8123](matrix-org/synapse#8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](matrix-org/synapse#8124)) - Update the test federation client to handle streaming responses. ([\#8130](matrix-org/synapse#8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](matrix-org/synapse#8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](matrix-org/synapse#8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](matrix-org/synapse#8164), [\#8179](matrix-org/synapse#8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](matrix-org/synapse#8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](matrix-org/synapse#8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](matrix-org/synapse#8174), [\#8181](matrix-org/synapse#8181)) - Standardize the mypy configuration. ([\#8175](matrix-org/synapse#8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](matrix-org/synapse#8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](matrix-org/synapse#8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](matrix-org/synapse#8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](matrix-org/synapse#8204), [\#8205](matrix-org/synapse#8205), [\#8222](matrix-org/synapse#8222), [\#8224](matrix-org/synapse#8224), [\#8225](matrix-org/synapse#8225), [\#8231](matrix-org/synapse#8231), [\#8233](matrix-org/synapse#8233), [\#8234](matrix-org/synapse#8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](matrix-org/synapse#8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](matrix-org/synapse#8245)) - Stop sub-classing from object. ([\#8249](matrix-org/synapse#8249)) - Add more logging to debug slow startup. ([\#8264](matrix-org/synapse#8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](matrix-org/synapse#8266), [\#8276](matrix-org/synapse#8276))

This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](matrix-org/matrix-spec-proposals#2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed. The cache was added in #7785, but we forgot to ensure it was invalidated appropriately. Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.

* commit '0d4f614fd': Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225) Add experimental support for sharding event persister. (#8170) Add /user/{user_id}/shared_rooms/ api (#7785) Do not try to store invalid data in the stats table (#8226) Convert the main methods run by the reactor to async. (#8213)

richvdh · 2022-02-08T12:53:04Z

Note that #8290 removed this endpoint from workers.md

Half-Shot added 3 commits July 5, 2020 12:57

Add shared_rooms api

26634cb

Add changelog

0f6800f

Add .

984c52b

This was referenced Apr 4, 2023

Meta-issue: Show list of shared rooms with another user element-hq/element-meta#1366

Open

Add _unstable_getSharedRooms matrix-org/matrix-js-sdk#1417

Merged

MSC2666: Get rooms in common with another user matrix-org/matrix-spec-proposals#2666

Open

Half-Shot changed the title ~~Add /user/{user_id/shared_rooms/ api~~ Add /user/{user_id}/shared_rooms/ api Jul 5, 2020

Half-Shot added 2 commits July 5, 2020 13:46

Wrap response in {"rooms": }

f43bf0c

linting

9c1e934

Half-Shot force-pushed the hs/shared-with-api branch from cc30cd6 to 9c1e934 Compare July 5, 2020 12:53

Half-Shot mentioned this pull request Jul 5, 2020

Show rooms in common with another user matrix-org/matrix-react-sdk#4897

Closed

Add unstable_features key

208d3cf

Half-Shot force-pushed the hs/shared-with-api branch from f769991 to 208d3cf Compare July 5, 2020 13:17

Half-Shot added 7 commits July 5, 2020 14:25

Remove options from isort that aren't part of 5.x

90a5975

`-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020

Update imports to make isort happy

3fa92f5

Add changelog

6bd34c7

Update tox.ini file with correct invocation

09e09a3

Merge branch 'hs/isort-5' into hs/shared-with-api

c143e62

fix linting again for isort

676edea

Merge remote-tracking branch 'origin/develop' into hs/shared-with-api

c399292

tulir approved these changes Jul 6, 2020

View reviewed changes

Vendor prefix unstable API

dde46cf

anoadragon453 reviewed Jul 10, 2020

View reviewed changes

richvdh added the X-Awaiting-Changes A contributed PR which needs changes and re-review before it can be merged label Jul 29, 2020

Half-Shot added 2 commits August 29, 2020 10:01

Seperate unstable endpoint from v2

7554836

Add upgrade node

1fa8b84

Half-Shot requested a review from anoadragon453 August 29, 2020 09:01

a line

783f8f5

clokep reviewed Aug 31, 2020

View reviewed changes

synapse/rest/__init__.py Outdated Show resolved Hide resolved

Fix style by adding a blank line at EOF.

a444ab0

Half-Shot commented Aug 31, 2020

View reviewed changes

synapse/storage/databases/main/user_directory.py Outdated Show resolved Hide resolved

Update synapse/storage/databases/main/user_directory.py

837cf31

Co-authored-by: Tulir Asokan <tulir@maunium.net>

Merge remote-tracking branch 'origin/develop' into hs/shared-with-api

023e21f

anoadragon453 suggested changes Sep 2, 2020

View reviewed changes

Half-Shot and others added 2 commits September 2, 2020 12:07

Update synapse/storage/databases/main/user_directory.py

679810a

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Update UPGRADE.rst

0578bb9

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

anoadragon453 approved these changes Sep 2, 2020

View reviewed changes

UPGRADE.rst Outdated Show resolved Hide resolved

docs/workers.md Outdated Show resolved Hide resolved

tulir reviewed Sep 2, 2020

View reviewed changes

docs/workers.md Outdated Show resolved Hide resolved

Half-Shot and others added 2 commits September 2, 2020 12:17

Merge branch 'develop' into hs/shared-with-api

5acf573

Fix UPGRADE/CHANGELOG unstable paths

078b3e3

unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>

Half-Shot merged commit b257c78 into develop Sep 2, 2020

Half-Shot deleted the hs/shared-with-api branch September 2, 2020 12:18

anoadragon453 mentioned this pull request Sep 10, 2020

Remove MSC2666 info from upgrade/workers doc as it's still experimental #8290

Merged

anoadragon453 mentioned this pull request Feb 16, 2021

Remove cache for get_shared_rooms_for_users #9416

Merged

richvdh mentioned this pull request Feb 8, 2022

Shared rooms API doesn't work if the worker handling the request doesn't update the user directory #10339

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add /user/{user_id}/shared_rooms/ api #7785

Add /user/{user_id}/shared_rooms/ api #7785

Half-Shot commented Jul 5, 2020 •

edited

Loading

Half-Shot commented Jul 5, 2020 •

edited

Loading

tulir left a comment

anoadragon453 Jul 10, 2020

Half-Shot Jul 10, 2020

richvdh commented Jul 28, 2020

anoadragon453 commented Jul 28, 2020

richvdh commented Jul 29, 2020

richvdh commented Jul 29, 2020

Half-Shot commented Jul 31, 2020

Half-Shot commented Aug 31, 2020

anoadragon453 left a comment

anoadragon453 Sep 2, 2020

Half-Shot Sep 2, 2020

anoadragon453 Sep 2, 2020

Half-Shot commented Sep 2, 2020

anoadragon453 left a comment

anoadragon453 commented Sep 2, 2020

Half-Shot commented Sep 2, 2020 •

edited

Loading

richvdh commented Feb 8, 2022

	raise AuthError(403, "Cannot get shared rooms for other users.")
	raise AuthError(403, "Cannot get shared rooms between other users.")

Add /user/{user_id}/shared_rooms/ api #7785

Add /user/{user_id}/shared_rooms/ api #7785

Conversation

Half-Shot commented Jul 5, 2020 • edited Loading

Leftover things to implement from the MSC

Pull Request Checklist

Half-Shot commented Jul 5, 2020 • edited Loading

tulir left a comment

Choose a reason for hiding this comment

anoadragon453 Jul 10, 2020

Choose a reason for hiding this comment

Half-Shot Jul 10, 2020

Choose a reason for hiding this comment

richvdh commented Jul 28, 2020

anoadragon453 commented Jul 28, 2020

richvdh commented Jul 29, 2020

richvdh commented Jul 29, 2020

Half-Shot commented Jul 31, 2020

Half-Shot commented Aug 31, 2020

anoadragon453 left a comment

Choose a reason for hiding this comment

anoadragon453 Sep 2, 2020

Choose a reason for hiding this comment

Half-Shot Sep 2, 2020

Choose a reason for hiding this comment

anoadragon453 Sep 2, 2020

Choose a reason for hiding this comment

Half-Shot commented Sep 2, 2020

anoadragon453 left a comment

Choose a reason for hiding this comment

anoadragon453 commented Sep 2, 2020

Half-Shot commented Sep 2, 2020 • edited Loading

richvdh commented Feb 8, 2022

Half-Shot commented Jul 5, 2020 •

edited

Loading

Half-Shot commented Jul 5, 2020 •

edited

Loading

Half-Shot commented Sep 2, 2020 •

edited

Loading