Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept invites based on space membership #125

Closed
Twi1ightSparkle opened this issue Aug 18, 2021 · 3 comments
Closed

Accept invites based on space membership #125

Twi1ightSparkle opened this issue Aug 18, 2021 · 3 comments

Comments

@Twi1ightSparkle
Copy link

Now that spaces are about to come out of beta, we should add the option for Mjolnir to accept room invitations based on if the inviter is in a certain space. Similar to how acceptInvitesFromGroup works today.

Possibly also deprecate the acceptInvitesFromGroup option at the same time?

@Yoric
Copy link
Contributor

Yoric commented Aug 18, 2021

So, a pref that tells a Mjolnir deployment to accept all invites from inviters who belong to a given space?
Is there an API to determine that a user belongs to a space?

@turt2live
Copy link
Member

The same APIs that tell you if a user is a member of a room: Spaces are Rooms.

Gnuxie added a commit that referenced this issue Jul 27, 2022
#125
#99

acceptInvitesFromGroup was implemented with an experimental api
that was a precursor to spaces which was refereed to
as either communities or groups.
Support for communities/groups ended in Synapse 1.61.0
https://github.com/matrix-org/synapse/releases/tag/v1.61.0.
Gnuxie added a commit that referenced this issue Aug 17, 2022
Replace acceptInvitesFromGroup with acceptInvitesFromSpace.

#125
#99

acceptInvitesFromGroup was implemented with an experimental api
that was a precursor to spaces which was refereed to
as either communities or groups.
Support for communities/groups ended in Synapse 1.61.0
https://github.com/matrix-org/synapse/releases/tag/v1.61.0.

To test we just edit the config dynamically which changes how the join room listener functions
though idk, shouldn't we have just made a new mjolnir instance
for this test, or changed the config before the test started somehow?


Co-authored-by: jesopo <github@lolnerd.net>
@Gnuxie
Copy link
Contributor

Gnuxie commented Aug 17, 2022

#338

@Gnuxie Gnuxie closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants