Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bans from protections being unbannable #393

Closed
Gnuxie opened this issue Oct 28, 2022 · 0 comments · Fixed by #402
Closed

Fix bans from protections being unbannable #393

Gnuxie opened this issue Oct 28, 2022 · 0 comments · Fixed by #402

Comments

@Gnuxie
Copy link
Contributor

Gnuxie commented Oct 28, 2022

FirstMessageIsImage + Flooding protection are the usual culprits for this

There's an internal queue for each that doesn't get flushed when you use unban
Gnuxie added a commit that referenced this issue Nov 1, 2022
@Gnuxie
Clear internal queues within protections when unban happens.
9386195 
#393
@Gnuxie Gnuxie mentioned this issue Nov 1, 2022
Merged
Gnuxie added a commit that referenced this issue Nov 7, 2022
@Gnuxie
Improve the clarity of the unban command (#402)
fb52e3d 
Also fix a years long bug where the Flooding/Media protection wouldn't stop redacting users

Closes #393
Closes #394

* Warn about room level bans when using unban

#394

* Clear internal queues within protections when unban happens.

#393
Yoric pushed a commit that referenced this issue Nov 8, 2022
@Gnuxie @Yoric
Improve the clarity of the unban command (#402)
be03626 
Also fix a years long bug where the Flooding/Media protection wouldn't stop redacting users

Closes #393
Closes #394

* Warn about room level bans when using unban

#394

* Clear internal queues within protections when unban happens.

#393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the clarity of the unban command matrix-org/mjolnir
1 participant
@Gnuxie