Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

MyPy-lint the whole codebase #9741

Closed
ShadowJonathan opened this issue Apr 3, 2021 · 3 comments
Closed

MyPy-lint the whole codebase #9741

ShadowJonathan opened this issue Apr 3, 2021 · 3 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Apr 3, 2021

This is a bit of a "sentinel" issue, to be able to mypy-check the whole of synapse/ and tests/, at the very least.

While working on #9682 i noticed that mypy is missing a lot of corners, so im making this issue to work towards.


Simply; the goal is to reduce the [mypy] -> files= key in this file down to synapse/,, so that one mypy pass goes over the entire database unequivocally.

@ShadowJonathan ShadowJonathan changed the title [sentinel] Mypy-lint the whole codebase [sentinel] MyPy-lint the whole codebase Apr 3, 2021
@clokep
Copy link
Member

clokep commented Apr 5, 2021

Is this essentially #8351?

@ShadowJonathan
Copy link
Contributor Author

No, that issue calls for var: Type instead of var = [...] # type: Type, it also calls for more variable annotations.

What this issue is about is to make these lines effectively only be synapse/,, so to speak, to have mypy check the entire synapse/ codebase instead of a subset of subdirectories and files.

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 5, 2021
@ShadowJonathan ShadowJonathan changed the title [sentinel] MyPy-lint the whole codebase MyPy-lint the whole codebase Jul 9, 2021
@clokep
Copy link
Member

clokep commented Dec 14, 2021

Closing in favor of #11271.

@clokep clokep closed this as completed Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

2 participants