New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor matrixfederationclient to fix logging #3906

Merged
merged 10 commits into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Sep 18, 2018

We want to wait until we have read the response body before we log the request as complete, otherwise a confusing thing happens where the request appears to have completed, but we later fail it.

To do this, we factor the salient details of a request out to a separate object, which can then keep track of the txn_id, so that it can be logged.

richvdh and others added some commits Sep 17, 2018

Refactor matrixfederationclient to fix logging
We want to wait until we have read the response body before we log the request
as complete, otherwise a confusing thing happens where the request appears to
have completed, but we later fail it.

To do this, we factor the salient details of a request out to a separate
object, which can then keep track of the txn_id, so that it can be logged.
Merge branch 'rav/federation_request_logging' of ssh://github.com/mat…
…rix-org/synapse into rav/federation_request_logging

@richvdh richvdh requested a review from matrix-org/synapse-core Sep 18, 2018

@hawkowl

lgtm, plus it has some testing

@richvdh

This comment has been minimized.

Member

richvdh commented Sep 18, 2018

plus it has some testing

written by an expert.

@richvdh richvdh merged commit 31c15dc into develop Sep 18, 2018

14 checks passed

Synapse Sytest Postgres (Commit) Build #7093 origin/rav/federation_request_logging succeeded in 6 min 39 sec
Details
Synapse Sytest Postgres (Merged PR) Build finished.
Details
Synapse Sytest SQLite (Commit) Build #7308 origin/rav/federation_request_logging succeeded in 4 min 5 sec
Details
Synapse Sytest SQLite (Merged PR) Build finished.
Details
ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/federation_request_logging branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment