Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sending v2 invites to server #545

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Conversation

erikjohnston
Copy link
Member

This PR is in two parts.

In the second part I've tried to reuse as much code as possible between invite_server using v1 and v2 APIs, but it feels fairly ming :/ Alternate suggestions welcome.

Tests matrix-org/synapse#4402

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit ming, but I've seen a lot worse and I can't think of anything better.

lgtm modulo the comment nits

tests/50federation/35room-invite.pl Outdated Show resolved Hide resolved
tests/50federation/35room-invite.pl Outdated Show resolved Hide resolved
@erikjohnston erikjohnston merged commit cd3e3c5 into develop Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants