New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC 1813 - Add room version to make APIs #4447

Merged
merged 4 commits into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 23, 2019

We also implement make_membership_event converting the returned on.

Based on #4437

Implement MSC 1813 - Add room version to make APIs
We also implement `make_membership_event` converting the returned
room version to an event format version.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4447 into develop will increase coverage by 0.02%.
The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           develop    #4447      +/-   ##
===========================================
+ Coverage    74.77%   74.79%   +0.02%     
===========================================
  Files          336      336              
  Lines        34023    34031       +8     
  Branches      5533     5534       +1     
===========================================
+ Hits         25439    25454      +15     
+ Misses        7014     7004      -10     
- Partials      1570     1573       +3

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 23, 2019

int
"""
if room_version not in KNOWN_ROOM_VERSIONS:
raise

This comment has been minimized.

@richvdh

richvdh Jan 24, 2019

Member

need to raise something here

where origin is the remote homeserver which generated the event.
Deferred[tuple[str, dict, int]]: resolves to a tuple of
`(origin, event, event_format)` where origin is the remote
homeserver which generated the event.

This comment has been minimized.

@richvdh

richvdh Jan 24, 2019

Member

could you clarify that event_format is one of the values in synapse.api.constants.EventFormatVersions ?

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 24, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston force-pushed the erikj/msc_1813 branch from 51d6a93 to 62514bb Jan 25, 2019

@erikjohnston erikjohnston merged commit 28c21cd into develop Jan 25, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specify the room_version response property on /make_{leave|join}
Original proposal: #1813
Implementation proof: matrix-org/synapse#4447

There are no changes from the original proposal.

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specify the room_version response property on /make_{leave|join}
Original proposal: #1813
Implementation proof: matrix-org/synapse#4447

There are no changes from the original proposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment