New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for persisting event format versions #4437

Merged
merged 4 commits into from Jan 24, 2019

Conversation

4 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 23, 2019

Currently we only have the one event format version defined, but this
adds the necessary infrastructure to persist and fetch the format
versions alongside the events.

We specify the format version rather than the room version as:

  1. We don't necessarily know the room version, existing events may be
    either v1 or v2.
  2. We'd need to be careful to prevent/handle correctly if different
    events in the same room reported to be of different versions, which
    sounds annoying.

erikjohnston added some commits Jan 23, 2019

Add support for persisting event format versions
Currently we only have the one event format version defined, but this
adds the necessary infrastructure to persist and fetch the format
versions alongside the events.

We specify the format version rather than the room version as:

1. We don't necessarily know the room version, existing events may be
   either v1 or v2.
2. We'd need to be careful to prevent/handle correctly if different
   events in the same room reported to be of different versions, which
   sounds annoying.

@erikjohnston erikjohnston force-pushed the erikj/event_format_version_v2 branch from f3234e0 to 4cd50d9 Jan 23, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #4437 into develop will increase coverage by 0.04%.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop    #4437      +/-   ##
===========================================
+ Coverage    73.58%   73.63%   +0.04%     
===========================================
  Files          301      302       +1     
  Lines        29822    29824       +2     
  Branches      4894     4896       +2     
===========================================
+ Hits         21946    21962      +16     
+ Misses        6446     6429      -17     
- Partials      1430     1433       +3

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 23, 2019

@erikjohnston erikjohnston added this to To Do in Homeserver Task Board via automation Jan 23, 2019

@erikjohnston erikjohnston moved this from To Do to In progress in Homeserver Task Board Jan 23, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 24, 2019

This is split out from #4403. I've addressed the review comments that were there, including moving delta file to 53, and adding back in the imports used for auto completion, and generally killed spurious changes.

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 664b7a2 into develop Jan 24, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl moved this from In progress to Done in Homeserver Task Board Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment