This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Require event format version to parse or create events #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also implement `make_membership_event` converting the returned room version to an event format version.
…/synapse into erikj/require_format_version
Codecov Report
@@ Coverage Diff @@
## develop #4451 +/- ##
===========================================
+ Coverage 74.77% 74.77% +<.01%
===========================================
Files 336 336
Lines 34023 34071 +48
Branches 5533 5538 +5
===========================================
+ Hits 25439 25475 +36
- Misses 7014 7025 +11
- Partials 1570 1571 +1 |
|
This was split out from #4403, and addresses the review comments that were there. |
…quire_format_version
This was referenced Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4405, #4437, #4447 and #4448
The vast majority of this PR is simply adding in the format version when parsing events from federation