Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor event signing to work on dicts #4493

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Refactor event signing to work on dicts #4493

merged 2 commits into from
Jan 29, 2019

Conversation

erikjohnston
Copy link
Member

This is in preparation for making EventBuilder format agnostic, which
means event signing should be done against the event dict rather than
the EventBuilder object.

@erikjohnston
Refactor event signing to work on dicts
855a151 
This is in preparation for making EventBuilder format agnostic, which
means event signing should be done against the event dict rather than
the EventBuilder object.
@erikjohnston
Newsfile
b8bea34
@erikjohnston erikjohnston requested a review from a team January 28, 2019 16:53
@erikjohnston erikjohnston mentioned this pull request Jan 28, 2019
Merged
richvdh
richvdh approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 17709f8 into develop Jan 29, 2019
erikjohnston added a commit that referenced this pull request Jan 29, 2019
@erikjohnston
Fixup calls to comput_event_signature
6598992 
We currently pass FrozenEvent instead of `dict` to
`compute_event_signature`, which works by accident due to `dict(event)`
producing the correct result.

This fixes PR #4493 commit 855a151
@erikjohnston erikjohnston mentioned this pull request Jan 29, 2019
Merged
@erikjohnston erikjohnston deleted the erikj/refactor_event_signing branch March 5, 2019 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjohnston @richvdh