New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event signing to work on dicts #4493

Merged
merged 2 commits into from Jan 29, 2019

Conversation

2 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 28, 2019

This is in preparation for making EventBuilder format agnostic, which
means event signing should be done against the event dict rather than
the EventBuilder object.

erikjohnston added some commits Jan 28, 2019

Refactor event signing to work on dicts
This is in preparation for making EventBuilder format agnostic, which
means event signing should be done against the event dict rather than
the EventBuilder object.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 28, 2019

@erikjohnston erikjohnston added this to To Do in Homeserver Task Board via automation Jan 28, 2019

@erikjohnston erikjohnston moved this from To Do to In progress in Homeserver Task Board Jan 28, 2019

@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 17709f8 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikjohnston erikjohnston moved this from In progress to Done in Homeserver Task Board Jan 29, 2019

erikjohnston added a commit that referenced this pull request Jan 29, 2019

Fixup calls to `comput_event_signature`
We currently pass FrozenEvent instead of `dict` to
`compute_event_signature`, which works by accident due to `dict(event)`
producing the correct result.

This fixes PR #4493 commit 855a151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment