This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add simple relations API #5186
Merged
Add simple relations API #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/simple_pagination
branch
2 times, most recently
from
cb457ee
to
920f9b1
Compare
Codecov Report
@@ Coverage Diff @@
## erikj/reactions_base #5186 +/- ##
=======================================================
Coverage ? 62.26%
=======================================================
Files ? 338
Lines ? 34786
Branches ? 5689
=======================================================
Hits ? 21661
Misses ? 11583
Partials ? 1542 |
Codecov Report
@@ Coverage Diff @@
## erikj/reactions_base #5186 +/- ##
=======================================================
Coverage ? 62.27%
=======================================================
Files ? 338
Lines ? 34791
Branches ? 5687
=======================================================
Hits ? 21666
Misses ? 11583
Partials ? 1542 |
erikjohnston
force-pushed
the
erikj/simple_pagination
branch
from
920f9b1
to
5fb72e6
Compare
richvdh
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple relations API. Hopefully the commits make sense by themselves. Note that this is being PR'ed against a random base branch, as I don't want things to land on develop yet.
This implements matrix-org/matrix-spec-proposals#1849