This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add relation aggregation APIs #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/relations_aggregations
branch
2 times, most recently
from
1e0ee71
to
467678e
Compare
Codecov Report
@@ Coverage Diff @@
## erikj/reactions_base #5192 +/- ##
=======================================================
+ Coverage 62.27% 62.4% +0.13%
=======================================================
Files 338 338
Lines 34791 34955 +164
Branches 5687 5713 +26
=======================================================
+ Hits 21666 21814 +148
- Misses 11583 11595 +12
- Partials 1542 1546 +4 |
erikjohnston
force-pushed
the
erikj/relations_aggregations
branch
from
467678e
to
0983c87
Compare
erikjohnston
force-pushed
the
erikj/relations_aggregations
branch
from
0983c87
to
a060352
Compare
erikjohnston
force-pushed
the
erikj/relations_aggregations
branch
from
8278ea7
to
b5c62c6
Compare
2 tasks
richvdh
approved these changes
May 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5186.Does rely on #5191, but that has already been merged in the base branch.The actual bundling of relations into events is disabled by default, but can be enabled via the undocumented
experimental_msc1849_support_enabledconfig flag.