Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in self signing key tests. #822

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

erikjohnston
Copy link
Member

Though this does raise a bit of a scary thought: there's no guarantee that just because we've told clients about a device change doesn't mean the rest of the workers know about it yet

@clokep
Copy link
Member

clokep commented Mar 3, 2020

I think the code looks good, but I'm not confident in evaluating the implications of what you've said above:

there's no guarantee that just because we've told clients about a device change doesn't mean the rest of the workers know about it yet

@erikjohnston erikjohnston merged commit ee33ef3 into develop Mar 3, 2020
@erikjohnston erikjohnston deleted the erikj/fixup_devices_stream branch March 3, 2020 15:38
@erikjohnston
Copy link
Member Author

Merging to fix flakey test. We should think about scary thoughts separately.

anoadragon453 added a commit that referenced this pull request Mar 24, 2020
…ease-v1.12.x

* origin/release-v1.12.0:
  Missing bits
  Use r0 instead of 'unstable' for joined_members|rooms
  Add test to optionally keep other sessions when modifying a user's password. (#832)
  Remove tests that call query_auth endpoint. (#827)
  Add tests for validating alt_aliases of a canonical alias event. (#824)
  Update the haproxy config to route fallback auth and register to the same worker. (#828)
  Add tests for a user with sufficient power level removing an alias. (#818)
  Add a test for an event with an invalid signature (#821)
  Fix race in self signing key tests. (#822)
  Use retry_until_success instead of repeat_until_true.
  Attempt to deflake a test.
  Fix frontend proxy worker binding to wrong port. (#823)
  Stop checking for aliases in the public room list.
  Attempt to deflake a sytest (#816)
  Fix formatting from review.
  Support running Dendrite in more than 1 sqlite db file
  Add tests for moving alt_aliases to an upgraded room.
  Support running dendrite in sqlite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants