clean up func getPkValueExpr #14378
Merged
clean up func getPkValueExpr #14378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensenojs
requested review from
ouyuanning,
aunjgr and
badboynt1
as code owners
|
本地用tpcc , warehouses=10, runMin=3跑了三次, 其测试结果如下所示 
|
|
不要只特判rowcnt==1, 改成rowcnt<=3是不是更好一点？ |
ouyuanning
approved these changes
Jan 31, 2024
在本地的main分支上测试的结果看确实如此 |
jensenojs
force-pushed
the
clean_getPkValueExpr_1.1
branch
from
4834c8d
to
6451edd
Compare
7 tasks
badboynt1
approved these changes
Jan 31, 2024
sukki37
approved these changes
Jan 31, 2024
sukki37
added a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #13987
What this PR does / why we need it:
use IN instead of OR for cpk and fix a typo
the special case of rowCnt == 1 is retained, otherwise the performance of tpcc will be significantly reduced.