Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the old fast ranges and update metrics. #16350

Merged
merged 16 commits into from
May 23, 2024
Merged

remove the old fast ranges and update metrics. #16350

merged 16 commits into from
May 23, 2024

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented May 23, 2024 •
edited
Loading

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##16146

What this PR does / why we need it:

  1. remove the old fast path
  2. check the pushed-down composite primary key serialization.
  3. update ranges metrics.

@matrix-meow matrix-meow added the size/M Denotes a PR that changes [100,499] lines label May 23, 2024
@matrix-meow matrix-meow added size/L Denotes a PR that changes [500,999] lines and removed size/M Denotes a PR that changes [100,499] lines labels May 23, 2024
@matrix-meow matrix-meow added size/XL Denotes a PR that changes [1000, 1999] lines and removed size/L Denotes a PR that changes [500,999] lines labels May 23, 2024
@mergify mergify bot merged commit e4c504a into matrixorigin:main May 23, 2024
17 of 19 checks passed
gouhongshen added a commit to gouhongshen/matrixone that referenced this pull request May 25, 2024
@gouhongshen
Revert "remove the old fast ranges and update metrics. (matrixorigin#…
1715eca 
…16350)"

This reverts commit e4c504a.
sukki37 pushed a commit that referenced this pull request May 25, 2024
@gouhongshen
Revert "remove the old fast ranges and update metrics. (#16350)" (#16400
150ae03 
)

This reverts commit e4c504a.

## What type of PR is this?

- [ ] API-change
- [ ] BUG
- [ ] Improvement
- [ ] Documentation
- [ ] Feature
- [ ] Test and CI
- [ ] Code Refactoring

## Which issue(s) this PR fixes:
issue ##16379


## What this PR does / why we need it:
revert to avoid oom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptend aptend aptend approved these changes

@XuPeng-SH XuPeng-SH XuPeng-SH approved these changes

@zhangxu19830126 zhangxu19830126 zhangxu19830126 approved these changes

@triump2020 triump2020 Awaiting requested review from triump2020 triump2020 is a code owner

Assignees
No one assigned
Labels
kind/enhancement size/XL Denotes a PR that changes [1000, 1999] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gouhongshen @zhangxu19830126 @XuPeng-SH @aptend @matrix-meow