Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ut/TestKill #16391

Merged
merged 8 commits into from
May 27, 2024
Merged

fix ut/TestKill #16391

merged 8 commits into from
May 27, 2024

Conversation

xzxiong
Copy link
Contributor

@xzxiong xzxiong commented May 24, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##16385

What this PR does / why we need it:

changes:

  1. return new txnOp while call txnClinet.New in UT/TestKill.

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label May 24, 2024
@mergify mergify bot added kind/bug Something isn't working kind/test-ci labels May 24, 2024
@mergify mergify bot merged commit 8a5f0bd into matrixorigin:main May 27, 2024
18 of 19 checks passed
@xzxiong xzxiong deleted the fix_ut_TestKill branch May 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviszhen daviszhen daviszhen approved these changes

@qingxinhome qingxinhome Awaiting requested review from qingxinhome qingxinhome is a code owner

Assignees
No one assigned
Labels
kind/bug Something isn't working kind/test-ci size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzxiong @daviszhen @matrix-meow