[cherry-pick-16594] : fix moc3399

[jensenojs]

User description

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/3399

What this PR does / why we need it:

When truncate table, if the table does not have any auto-incr col, there is no need to call the Reset interface of increment_service

---

PR Type

Bug fix

---

Description

• Added logic to check for the presence of auto-increment columns before calling the Reset method of incrservice in the TruncateTable function.
• Added logic to check for the presence of auto-increment columns before calling the Delete method of incrservice in the DropTable function.
• Prevented unnecessary calls to the auto-increment service if no auto-increment columns are present, optimizing performance and avoiding potential errors.

---

Changes walkthrough 📝

	Relevant files
Bug fix	ddl.go Add checks for auto-increment columns in table operations pkg/sql/compile/ddl.go Added checks for auto-increment columns before calling Reset in TruncateTable. Added checks for auto-increment columns before calling Delete in DropTable. Prevent unnecessary calls to incrservice if no auto-increment columns are present. +53/-21

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are localized to specific functions within a single file and involve adding conditional checks before performing operations. The logic is straightforward, making it relatively easy to review.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The check for auto-increment columns (if col.Typ.AutoIncr) assumes that all necessary columns are correctly defined in tblDef.Cols with the AutoIncr attribute properly set. If there are any discrepancies in how columns are defined or if the AutoIncr attribute is not set correctly even when it should be, this could lead to incorrect behavior where the Reset or Delete methods are not called when needed.
🔒 Security concerns	No

[codiumai-pr-agent-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Refactor repeated logic for checking auto-increment columns into a helper function To improve readability and maintainability, consider refactoring the repeated logic for checking if a table contains an auto-increment column into a separate helper function. This will reduce code duplication and make the code easier to manage. pkg/sql/compile/ddl.go [1962-1969] -tblDef := rel.GetTableDef(c.ctx) -var containAuto bool -for _, col := range tblDef.Cols { - if col.Typ.AutoIncr { - containAuto = true - break +containAuto := containsAutoIncrementColumn(rel.GetTableDef(c.ctx)) + +// Helper function +func containsAutoIncrementColumn(tblDef TableDef) bool { + for _, col := range tblDef.Cols { + if col.Typ.AutoIncr { + return true + } } + return false } Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies repeated code across multiple sections and proposes a maintainable solution by introducing a helper function. This significantly improves code maintainability and readability.	8
Possible bug	Add a nil check for tblDef to prevent potential nil pointer dereference Add a check to ensure tblDef is not nil before accessing its columns to avoid potential nil pointer dereference errors. pkg/sql/compile/ddl.go [1962-1964] tblDef := rel.GetTableDef(c.ctx) +if tblDef == nil { + return errors.New("table definition is nil") +} var containAuto bool for _, col := range tblDef.Cols { Suggestion importance[1-10]: 7 Why: This suggestion addresses a potential bug of nil pointer dereference by adding a nil check before accessing tblDef.Cols. This is a crucial check that enhances the robustness of the code.	7
Best practice	Log the error before returning it to aid in debugging Consider logging the error before returning it to provide more context for debugging purposes. pkg/sql/compile/ddl.go [1977-1978] if err != nil { + log.Errorf("Failed to reset auto-increment value: %v", err) return err } Suggestion importance[1-10]: 6 Why: Adding logging before returning an error is a good practice for debugging. This suggestion correctly identifies where additional context could be helpful for error analysis.	6
	Wrap the error with additional context for better traceability Use a consistent error handling approach by wrapping the error with additional context using fmt.Errorf for better error traceability. pkg/sql/compile/ddl.go [1977-1978] if err != nil { - return err + return fmt.Errorf("failed to reset auto-increment value: %w", err) } Suggestion importance[1-10]: 6 Why: Wrapping errors with additional context using fmt.Errorf is a best practice that aids in error traceability. This suggestion is correctly applied to the error handling in the code.	6