-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update delete by deltaloc #17246
update delete by deltaloc #17246
Conversation
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #17239
What this PR does / why we need it:
Update delete by deltaloc. Rollback and retry if the object is soft deleted
PR Type
Bug fix, Tests
Description
HasDropIntentLocked
method inBaseEntryImpl
to check for drop intent.TestDeltaLocation
test case to validate soft delete and retry logic.TryDeleteByDeltaloc
to check for drop intent before proceeding.PrepareCommit
inDeltalocChain
to include retry logic if there are new deletes or the object is soft deleted.Changes walkthrough 📝
base.go
Add method to check for drop intent in BaseEntryImpl
pkg/vm/engine/tae/catalog/base.go
HasDropIntentLocked
method to check for drop intent.db_test.go
Add test case for delta location and soft delete
pkg/vm/engine/tae/db/test/db_test.go
TestDeltaLocation
test case.base.go
Add drop intent check in TryDeleteByDeltaloc
pkg/vm/engine/tae/tables/base.go
TryDeleteByDeltaloc
.mvcc.go
Add retry logic for new deletes and soft deleted objects in
PrepareCommit
pkg/vm/engine/tae/tables/updates/mvcc.go
deleted in
PrepareCommit
.