-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] : fix increservice fill duplicated number during in multi-CN #17381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensenojs
requested review from
m-schen,
ouyuanning,
aunjgr and
badboynt1
as code owners
July 9, 2024 10:32
matrix-meow
added
size/M
Denotes a PR that changes [100,499] lines
and removed
size/S
Denotes a PR that changes [10,99] lines
labels
Jul 9, 2024
jensenojs
changed the title
[enhancement] : Maintain the last modified TxnTs fields for each columnCache
[fix] : fix increservice fill duplicated number during multi-CN
Jul 9, 2024
matrix-meow
added
size/L
Denotes a PR that changes [500,999] lines
and removed
size/M
Denotes a PR that changes [100,499] lines
labels
Jul 10, 2024
jensenojs
changed the title
[fix] : fix increservice fill duplicated number during multi-CN
[fix] : fix increservice fill duplicated number during in multi-CN
Jul 11, 2024
heni02
approved these changes
Jul 11, 2024
m-schen
approved these changes
Jul 11, 2024
zhangxu19830126
approved these changes
Jul 16, 2024
jensenojs
added a commit
to jensenojs/matrixone
that referenced
this pull request
Jul 17, 2024
…ti-CN (matrixorigin#17381)" This reverts commit 07dd980.
sukki37
pushed a commit
that referenced
this pull request
Jul 17, 2024
1 task
jensenojs
added a commit
to jensenojs/matrixone
that referenced
this pull request
Jul 26, 2024
…atrixorigin#17381) `preInsert`算子在给`auto pk col`生成值后, 会再加一个`Relation.PrimaryKeysMayBeModified`的检查, 检查`columnCache`更新的最后时间段(`fromTS`), 到此次sql期间(`toTS`), `incrservice`给出的值是否已经被`Modified`了, 如果是的话, 那直接retry这个sql. 这个场景会出现的原因是, 用户于其他的`CN`在`insert auto pk col`的时候手动指定了`values`的值, 并且这个值是在本CN的`incrservice cache`的区间中.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #16493
What this PR does / why we need it:
preInsert
算子在给auto pk col
生成值后, 会再加一个Relation.PrimaryKeysMayBeModified
的检查, 检查columnCache
更新的最后时间段(fromTS
), 到此次sql期间(toTS
),incrservice
给出的值是否已经被Modified
了, 如果是的话, 那直接retry这个sql.这个场景会出现的原因是, 用户于其他的
CN
在insert auto pk col
的时候手动指定了values
的值, 并且这个值是在本CN的incrservice cache
的区间中.