Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reloader issues #66

Merged
merged 13 commits into from
Aug 28, 2021
Merged

Fix Reloader issues #66

merged 13 commits into from
Aug 28, 2021

Conversation

matt-taylor
Copy link
Owner

When code was trying to get reloaded in development from

config.file_watcher = ActiveSupport::EventedFileUpdateChecker

The RailsBase configuration was getting wiped too. This caused magic methods that were magically defined, lost and unavailable.

@guardrails
Copy link

guardrails bot commented Aug 28, 2021

⚠️ We detected 1 security issue in this pull request:

Insecure Processing of Data (1)
Docs Details
💡 Title: Potential XSS (unquoted template variable), Severity: Medium
If this is in error please login to your account: <a href=<%= RailsBase::ApplicationMailer::CONTACT_URL %>> Login link for <%= RailsBase.app_name %> </a>

More info on how to fix Insecure Processing of Data in Ruby.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@matt-taylor matt-taylor merged commit 0206c16 into main Aug 28, 2021
@matt-taylor matt-taylor deleted the reloader_issues branch August 28, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant