Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to github actions; test on a matrix; run eslint in CI #17

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Aug 14, 2023

This PR:

  • switches from travis-ci (which has become unreliable anyways) to Github Actions
  • tests in all supported node majors
  • adds eslint and runs it in CI as well (but only once; the tests run on each node version)

Note that the actions may not run on this PR until they're in the master branch of this repo, but you can view the results here: https://github.com/ljharb/language-tags/actions (you'll note the tests fail solely because coveralls isn't enabled on my fork)

This is the first PR to address #15 (comment); after this lands, I'll put up another that adds babel and restores older engines compatibility.

After this merges, you can add linting and tests as required status checks.

@mattcg mattcg merged commit d69f938 into mattcg:master Aug 14, 2023
@mattcg
Copy link
Owner

mattcg commented Aug 14, 2023

Thank you for this!

@ljharb ljharb deleted the eslint branch August 14, 2023 15:04
@ljharb
Copy link
Contributor Author

ljharb commented Aug 14, 2023

@mattcg whoops, turns out i should be using the coveralls github action instead of | coveralls; the next PR will fix that.

@ljharb ljharb mentioned this pull request Aug 15, 2023
@ljharb
Copy link
Contributor Author

ljharb commented Aug 15, 2023

#18 fixes coverage; still working on the babel change.

@ljharb
Copy link
Contributor Author

ljharb commented Aug 15, 2023

#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants