-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Help Wanted] After using ctrl+k, an added row appears in msg box #426
Comments
Thanks @rholmboe for the report! Does this reproduce on the Chrome browser? Would you have a sample screenshot to share? |
@jasonblais This doesn't reproduce on a Chrome browser. Sadly I cant share a sample without displaying sensitive information. But the fault is very easy to reproduce. Activate search by using ctrl+k, type in your wanted channel and press enter twice, one for select channel in search box and one to press "switch" button. I just found out that it doesn't reproduce when using mouse to click on "switch" in the search box tho. So it should be limited for when using enter to switch channel within the search box. |
Ah yes, I'm able to reproduce it on Windows 10 as well. Thanks for the report! |
No worries, glad I could help. Awesome product, keep the good work up :) |
@jasonblais I feel this issue was fixed by upgrading Electron in #459. Would you confirm with the latest build? https://circleci.com/gh/mattermost/desktop/909#artifacts |
You're correct @yuya-oc, I'm no longer able to reproduce it on the latest build you provided |
Thanks for testing. I will update the changelog. |
I confirm (by marking "x" in the [ ] below):
Summary
Linux: After using ctrl+k, an added row appears in msg box
Steps to reproduce
Please include:
Linux/Ubuntu 16.10
3.5.0
3.6.0
In a channel, use ctrl+k to search for another channel and press enter, "write a message..." msg box adds another row in it.
Expected behavior
One-row msg box with focus() for direct writing.
Observed behavior
Dual-row msg box with focus() appears, and either first or second row is in focus.
Possible fixes
The text was updated successfully, but these errors were encountered: