Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tab bar height #489

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Mar 25, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Reduce tab bar height.

It seems that Chrome's tabs have about 28px of height at 100% of scaling.
But 28px looked a little narrow for me. So I used 32px. It always becomes an integer on monitor at all scaling.

  • 100% -> 32 dots on monitor
  • 125% -> 40 dots on monitor
  • 150% -> 48 dots on monitor

tab-height_100
tab-height_125
tab-height_150

Issue link
#462

Test Cases

  1. Add two servers at least to show the tab bar.
  2. Get unread mention to show badges.

Please also check that webapp doesn't looks blurry.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/196#artifacts

@jasonblais
Copy link
Contributor

jasonblais commented Mar 25, 2017

I still found it blurry at 125% and above - not sure if it's visible from the screenshot below

image

The tab height itself looks good to me (screenshot below at 100% for comparison). All text in the server bar is vertically centered 👍

image

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Mar 26, 2017

Did you log out from Windows after changing the scaling? It's necessary in order to properly apply the new scaling. Would you try again?

comparison_at_125

@jasonblais
Copy link
Contributor

Ah, right -- I'll test this out during the work week

@jasonblais
Copy link
Contributor

Confirmed that after system logout, the screen is no longer blurry. So all good for Windows

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Mar 31, 2017

Thanks! But the way to enable HiDPI on Mac is no longer working for me... Is there anyone who can use HiDPI?

@jasonblais
Copy link
Contributor

Lindsay helped test on a Retina display and said it looks good. I think we're okay to merge this one @yuya-oc even if we couldn't test on HiDPI mode (which is a retina mode in non-retina display)

image

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Apr 6, 2017

I see. Thanks!

@yuya-oc yuya-oc merged commit 2f40b51 into mattermost:master Apr 6, 2017
@yuya-oc yuya-oc deleted the reduce-tab-height branch April 6, 2017 11:59
@yuya-oc yuya-oc mentioned this pull request Apr 29, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants