Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Enable GPU hardware acceleration" option #734

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Mar 20, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Add "Enable GPU hardware acceleration" option.

It's enabled by default.

Issue link
#713

Test Cases

  • config.json (covered by CI)

    • enableHardwareAcceleration key is saved when clicking the option in the settings page.
  • Actual process

    1. Set Enable GPU hardware acceleration to disabled.
    2. Restart the app.
    3. Check running mattermost-desktop processes.
    4. Processes which have an argument --type=gpu-process should not exist.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/696#artifacts

@svelle
Copy link
Member

svelle commented Mar 20, 2018

Tested own build and CI-Build on Win 10 Pro x64 with AMD 18.3.1 Drivers and no problems so far, toggled GPU acceleration on and off a few times.
Will test Linux (Fedora 27) tomorrow morning and report back.

@jasonblais
Copy link
Contributor

jasonblais commented Mar 21, 2018

Great! Thanks @yuya-oc

Tested on Mac, one of the three Mattermost processes is removed after disabling the acceleration. I'll use the app with acceleration disabled today to see if there are any issues, but ready to merge from my side.

@amyblais please help test on Windows as well?

@amyblais
Copy link
Member

Tested on Windows as well and saw no issues either.

@jasonblais
Copy link
Contributor

I think this one is good to merge then @yuya-oc. Hopefully it helps with the blank page issues

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Mar 22, 2018

In my Ubuntu 16.04 VM, such process did not originally exist. Possibly because it's VM and hardware acceleration doesn't work well. However it's effective on other OS, so I think it's good to merge.

@yuya-oc yuya-oc merged commit 2b65319 into mattermost:master Mar 22, 2018
@yuya-oc yuya-oc deleted the enable-gpu-option branch March 22, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants