Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron to 1.8.4 #741

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Mar 26, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Upgrade Electron to 1.8.4.

As far as looking changelogs, important changes not found in functionality.

Issue link
#739

Test Cases
General usecases.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/704#artifacts

@yuya-oc yuya-oc added the All Platforms null label Mar 26, 2018
@yuya-oc yuya-oc added this to the v4.1.0 milestone Mar 26, 2018
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuya-oc Thanks! Given we haven't found any issues with #739 so far, this should be okay to merge

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Mar 26, 2018

Thanks!

@yuya-oc yuya-oc merged commit 0ecdb4d into mattermost:master Mar 26, 2018
@yuya-oc yuya-oc deleted the upgrade-electron branch March 26, 2018 13:43
@yuya-oc yuya-oc mentioned this pull request May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants