Introduce Storybook to preview React components #757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:js
for proper code formattingPlease provide the following information:
Summary
Introduce Storybook to preview React components. https://storybook.js.org/
We would be able to develop React components without executing/implementing the desktop app. It would be helpful when developing new components in future. And it would work also as the catalog of our React components.
Usage: Open http://localhost:9001/ while executing
npm run storybook
.Right now,
<Button>
is added as a sample. https://794-67276967-gh.circle-artifacts.com/0/storybook/index.htmlIssue link
N/A
Test Cases
Storybook app should be generated in CI.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/794#artifacts >
Container 0/storybook/index.html
=> https://794-67276967-gh.circle-artifacts.com/0/storybook/index.html