Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Storybook to preview React components #757

Merged
merged 4 commits into from
Apr 13, 2018

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Apr 12, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Introduce Storybook to preview React components. https://storybook.js.org/

We would be able to develop React components without executing/implementing the desktop app. It would be helpful when developing new components in future. And it would work also as the catalog of our React components.

Usage: Open http://localhost:9001/ while executing npm run storybook.

Right now, <Button> is added as a sample. https://794-67276967-gh.circle-artifacts.com/0/storybook/index.html

Issue link
N/A

Test Cases
Storybook app should be generated in CI.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/794#artifacts > Container 0/storybook/index.html
=> https://794-67276967-gh.circle-artifacts.com/0/storybook/index.html

@yuya-oc yuya-oc added this to the v4.1.0 milestone Apr 12, 2018
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! This should be a nice improvement, particularly with some of the upcoming end user features.

@yuya-oc yuya-oc merged commit 3fdcb64 into mattermost:master Apr 13, 2018
@yuya-oc yuya-oc deleted the storybook branch April 13, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants