Fix an error where the main page gets blank when adding a server #787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:js
for proper code formattingPlease provide the following information:
Summary
Fix an error where the main page gets blank when adding a server.
When adding a server on the main page, it tries to get focus to the new webview. However probably its webContents object is not created yet, so null reference error happened for me.
Issue link
N/A
Original report: https://pre-release.mattermost.com/core/pl/53y7wdj3wtye3pnewpfajzuatc
Test Cases
Add a server from
+
button of the main page or [File/Mattermost ->Sign in to Another Server] menu item.Additional Notes
https://circleci.com/gh/yuya-oc/desktop/822#artifacts