Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error where the main page gets blank when adding a server #787

Merged
merged 1 commit into from
May 4, 2018

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented May 3, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix an error where the main page gets blank when adding a server.

When adding a server on the main page, it tries to get focus to the new webview. However probably its webContents object is not created yet, so null reference error happened for me.

Issue link
N/A

Original report: https://pre-release.mattermost.com/core/pl/53y7wdj3wtye3pnewpfajzuatc

Test Cases
Add a server from + button of the main page or [File/Mattermost ->Sign in to Another Server] menu item.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/822#artifacts

Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works for me on Mac.

@DHaussermann
Copy link

This is now working in latest windows build.

@yuya-oc
Copy link
Contributor Author

yuya-oc commented May 4, 2018

Thanks!

@yuya-oc yuya-oc merged commit 59e2e7e into mattermost:release-4.1 May 4, 2018
@yuya-oc yuya-oc deleted the fix-add-server-error branch May 4, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants