Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_desktop_file.sh with categories #816

Merged
merged 1 commit into from
May 24, 2018

Conversation

dkadioglu
Copy link
Contributor

Before submitting, please confirm you've

Please provide the following information:

Summary
Add "Categories=Network;InstantMessaging;" to ensure that Mattermost is listed under the appropriate submenu of the application starter.

Test Cases
Tested with KDE/Plasma 5.46/5.12.5 and KMenu. With the change, Mattermost is listed under "Internet", without the change Mattermost is listed under "Lost & Found".

Add "Categories=Network;InstantMessaging;" to ensure that Mattermost is listed under the appropriate submenu of the application starter. Tested with KDE/Plasma 5.45 and KMenu.
@mattermod
Copy link
Contributor

Thanks @dkadioglu for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@jasonblais jasonblais requested a review from yuya-oc May 24, 2018 10:47
@jasonblais
Copy link
Contributor

Thanks for signing the CLA! Requesting first review from @yuya-oc

@yuya-oc
Copy link
Contributor

yuya-oc commented May 24, 2018

Looks good to me on Ubuntu 16.04+GNOME Classic. Mattermost moved from "Other" to "Internet".

@yuya-oc yuya-oc added the Linux label May 24, 2018
@yuya-oc yuya-oc added this to the v4.2.0 milestone May 24, 2018
@yuya-oc yuya-oc merged commit eb8a496 into mattermost:master May 24, 2018
@yuya-oc yuya-oc mentioned this pull request May 24, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants