Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup via config json #846

Merged
merged 3 commits into from
Sep 12, 2018
Merged

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Aug 10, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary

Issue link
https://mattermost.atlassian.net/browse/MM-11474

Test Cases

Case A: Confirm "app start on login" is on by default.

  1. Install then launch the app.
  2. Quit the app.
  3. Log out then log in.
  4. Confirm that the app launches on login

Case B: Edit config.json.

  1. Quit the app.
  2. Edit config.json to set autostart: false.
  3. Launch the app.
  4. Confirm that "app start on login" is disabled.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/957#artifacts

@esethna
Copy link
Contributor

esethna commented Aug 10, 2018

Awesome, thanks @yuya-oc!

@esethna
Copy link
Contributor

esethna commented Aug 27, 2018

Adding testing instructions for QA:

  1. Verify that after installing the preference for auto start on login is on by default
  2. config.json with desired text editor autostart: true -> autostart: false would disable auto-start when the app launches next time.

@lindy65
Copy link

lindy65 commented Sep 9, 2018

Thanks @yuya-oc @esethna

I installed 4.2 version from the artifact linked above and confirm that the app launches on start-up as expected. I did not know how to change the setting in the config.json but did change the setting via the app settings to autostart: false and confirm that the app did not launch on start-up.

PS: I added a label called QA tests done which is part of the new QA process of writing release tests at the stage of testing the resolved ticket.

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Sep 12, 2018

Thanks! I'll merge after resolving conflicts.

@yuya-oc yuya-oc merged commit 06acfcd into mattermost:master Sep 12, 2018
@yuya-oc yuya-oc deleted the startup-via-config-json branch September 12, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants