Upgrade Electron to 2.0.12 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yuya-oc is this for v4.2? |
|
@esethna If applicable, yes. It has also some minor security updates. |
crspeller
approved these changes
Oct 30, 2018
hmhealey
approved these changes
Oct 31, 2018
|
Looks good. @yuya-oc, I've assigned it back to you to merge, since I'm not sure if you have any special merge process. Let me know if I should just merge normally in the future |
|
Thanks all. Yeah, electron v2 is still updated by them, but we should move to v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Upgrade Electron to 2.0.12.
I believe there are no breaking changes from 2.0.8 to 2.0.12 as far as reading their release notes.
And I found Electron v3 and Spectron v5 break almost of our tests. I think it's hard to solve soon, so I used Electron v2.x.
Issue link
N/A
Test Cases
Automated tests. (
npm test)Additional Notes
https://circleci.com/gh/yuya-oc/desktop/1016#artifacts