Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update simple-spellchecker for new dict files #938

Merged
merged 2 commits into from
Feb 28, 2019
Merged

update simple-spellchecker for new dict files #938

merged 2 commits into from
Feb 28, 2019

Conversation

svelle
Copy link
Member

@svelle svelle commented Feb 27, 2019

@amyblais amyblais added the Hackfest null label Feb 27, 2019
@JtheBAB
Copy link
Contributor

JtheBAB commented Feb 27, 2019

@svelle I guess you need also to add here some changes:

desktop/src/package-lock.json

Line 635 in d93fb55

"simple-spellchecker": {

@svelle
Copy link
Member Author

svelle commented Feb 27, 2019

@svelle I guess you need also to add here some changes:

desktop/src/package-lock.json

Line 635 in d93fb55

"simple-spellchecker": {

good point. fixed!

This was referenced Feb 27, 2019
Closed
Closed
@wget wget self-requested a review February 27, 2019 16:07
@wget wget requested review from yuya-oc and cpanato and removed request for cpanato February 27, 2019 16:08
@wget
Copy link
Collaborator

wget commented Feb 27, 2019

As discussed, we will be using electron-spellchecker instead. We need to get the new CI merged first.

@yuya-oc yuya-oc merged commit 6aa99d8 into mattermost:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wget wget wget approved these changes

@yuya-oc yuya-oc yuya-oc approved these changes

Assignees
No one assigned
Labels
Hackfest null
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"online" is not recognised as a word by either English dictionary
5 participants
@svelle @JtheBAB @wget @yuya-oc @amyblais