[GH-993]: added support for subtasks in subscriptions #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickmister Added the first part of the changes as per our discussion on #993. Please have a look |
mickmister
approved these changes
Jul 4, 2024
webapp/src/components/modals/create_issue/__snapshots__/create_issue_form.test.tsx.snap
Show resolved
Hide resolved
There was a problem hiding this comment.
@raghavaggarwal2308 found a issue while testing this PR.
Issue: After creating the subtask, added subscriptions are not shown.
Step to reproduce:
- Create a new JIRA subscription for any channel
- Select the subtask for that subscription
- Create a new subtask
- Check the bot message on the channel
Expected: Subscription part is present in the bot message
Actual: Subscription part is missing in the bot message
Note: Mattermost Version: 8.1.0
|
@AayushChaudhary0001 You have to enable the below setting in system console to see that: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functionality to support
subtasksJira subscription.Screenshots
Old
New
Issues
Fixes #993
Fixes #859