Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Standard Tax rates for 1st Jan 2017 #1

Closed
wants to merge 1 commit into from

Conversation

johnnye
Copy link

@johnnye johnnye commented May 11, 2017

No description provided.

@mattes
Copy link
Owner

mattes commented May 16, 2017

thanks for bringing this up! living in the US now I wasn't aware of the change. I anticipated rate changes, that's why I added the *AtDate funcs but didn't implement them at that time.

I'm thinking about refactoring the var standardRate = map[string]float64{ map to something like:

type Rates struct {
  Since time.Time
  map[string]float64
}

var rates = []Rates{}

This would make it easy to just add partial changes for certain countries and have the *AtDate funcs recursively find the rate for a given date.

Is that change something you would want to look into? Otherwise I will do it as soon as I find more time.

@johnnye
Copy link
Author

johnnye commented May 16, 2017

I'm not sure. In that document there is also the non standard rates for various countries. I think that would be more useful then the historic rates. Having both would mean completeness.

@mattes
Copy link
Owner

mattes commented May 18, 2017

Closing this in favor or #2

@mattes mattes closed this May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants