-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI modernization #172
CI modernization #172
Conversation
Additionally, use CodeCov Action and update setup-python and use 'ubuntu-latest'
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 35.88% 34.02% -1.86%
==========================================
Files 53 52 -1
Lines 2302 2272 -30
Branches 0 336 +336
==========================================
- Hits 826 773 -53
+ Misses 1476 1419 -57
- Partials 0 80 +80
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. In general I like pinning versions for reproducibility (e.g. python here), but I'll defer to you on this, and indeed python isn't that important here! Thanks for taking the time to update things!
The version doesn't change the actual python version used in the build, but the python setup action. According to it's list of preinstalled software Python 3 is available by default anyway, so we can consider removing the action. I'll check this just to be safe here … :-) |
Oh! Perfect! Please go ahead as you see fit (happy to remove the python step too, or in another pr!) |
Migration of GCC / Clang builds to Docker images. This enables eg. newer compiler version without messing with the host OS.
Additionally:
ubuntu-latest
(Runner)setup-python
tomain
(instead of a fixed version)Please note: As before there's no coverage upload on Clang, since it doesn't produce data.