Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI modernization #172

Merged
merged 3 commits into from
Aug 29, 2022
Merged

CI modernization #172

merged 3 commits into from
Aug 29, 2022

Conversation

offa
Copy link
Collaborator

@offa offa commented Aug 26, 2022

Migration of GCC / Clang builds to Docker images. This enables eg. newer compiler version without messing with the host OS.

Additionally:

  • GCC 12 added
  • Update to ubuntu-latest (Runner)
  • Update setup-python to main (instead of a fixed version)
  • Migration to CodeCov Github Action

Please note: As before there's no coverage upload on Clang, since it doesn't produce data.

Additionally, use CodeCov Action and update setup-python
and use 'ubuntu-latest'
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #172 (a796427) into master (100dbeb) will decrease coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   35.88%   34.02%   -1.86%     
==========================================
  Files          53       52       -1     
  Lines        2302     2272      -30     
  Branches        0      336     +336     
==========================================
- Hits          826      773      -53     
+ Misses       1476     1419      -57     
- Partials        0       80      +80     
Impacted Files Coverage Δ
src/main/c/sha1/sha1.cpp 69.56% <0.00%> (-5.80%) ⬇️
src/main/c/StringUtil.cpp 83.78% <0.00%> (-5.41%) ⬇️
src/main/c/Server.cpp 20.92% <0.00%> (-5.16%) ⬇️
src/main/c/HybiPacketDecoder.cpp 73.43% <0.00%> (-4.69%) ⬇️
src/main/c/Connection.cpp 17.50% <0.00%> (-2.37%) ⬇️
src/main/c/util/CrackedUri.cpp 96.42% <0.00%> (-0.07%) ⬇️
src/main/c/seasocks/Credentials.h 0.00% <0.00%> (ø)
src/main/c/seasocks/StrCompare.h
src/main/c/seasocks/Logger.h 6.25% <0.00%> (+0.36%) ⬆️
src/main/c/seasocks/util/Json.h 87.20% <0.00%> (+1.00%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@offa offa requested a review from mattgodbolt August 29, 2022 05:24
Copy link
Owner

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. In general I like pinning versions for reproducibility (e.g. python here), but I'll defer to you on this, and indeed python isn't that important here! Thanks for taking the time to update things!

@offa
Copy link
Collaborator Author

offa commented Aug 29, 2022

The version doesn't change the actual python version used in the build, but the python setup action.

According to it's list of preinstalled software Python 3 is available by default anyway, so we can consider removing the action.

I'll check this just to be safe here … :-)

@mattgodbolt
Copy link
Owner

Oh! Perfect! Please go ahead as you see fit (happy to remove the python step too, or in another pr!)

@offa offa merged commit 025ff68 into mattgodbolt:master Aug 29, 2022
@offa offa deleted the ci/images branch August 29, 2022 16:26
@offa offa added this to the v1.4.6 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants