-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Update to TypeScript #316
Conversation
✔️ Deploy Preview for hauntedhooks ready! 🔨 Explore the source changes: 455d027 🔍 Inspect the deploy log: https://app.netlify.com/sites/hauntedhooks/deploys/61799c171d372200083bb0cf 😎 Browse the preview: https://deploy-preview-316--hauntedhooks.netlify.app |
Yes! Thank you so much! I'll leave it to @bennypowers to give their blessing as I know they've been wanting to move to
Not a hill to die on, but I think we should keep them anyways and not rely on node_modules resolution. |
This PR updates test infrastructure to
@web/test-runner
per #240 and converts all test files to TypeScript.Some notes on methodology:
cycle()
ornextFrame()
) where they were clearly duplicative or superfluous. However, I left some in places where they might not be strictly needed for a passing test, but seem good for testing: for instance, after auseState
or similar value is updated.src
instead of compiled code for this to work. Otherwise we getError: Invalid template provided - string or lit-html TemplateResult is supported
types-test.ts
; I added changes & comments to highlight these. After some investigation of those issues and landing this PR, we can probably delete that file..js
from imports in those test files. I needed to add those extensions formake
to work correctly.