Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSTV] cached epg on plugin.video.dstv.now broken #187

Closed
tinuva opened this issue Apr 28, 2022 · 13 comments
Closed

[DSTV] cached epg on plugin.video.dstv.now broken #187

tinuva opened this issue Apr 28, 2022 · 13 comments

Comments

@tinuva
Copy link

tinuva commented Apr 28, 2022

Hi,

The EPG from:
https://github.com/matthuisman/slyguy.addons/blob/master/plugin.video.dstv.now/resources/lib/constants.py#L12

ZA_EPG_URL = 'https://i.mjh.nz/DStv/za.xml.gz'

is no longer working. I suspect that is because it is based on http://guide.dstv.com/ which is now broken.

Instead https://www.dstv.com/en-za/discover/tv-guide/ works.

I create a fork of iptv-org at https://github.com/tinuva/epg which focus on the epg for dstv.za

Any chance we can get the addon updated to use https://tinuva.github.io/epg/guides/za/dstv.com.epg.xml.gz ?
I confirmed works with the plugin by replacing the above line 12 with this url.

Alternatively would be great if we can get a list of cached options to select from in the addon settings to allow users the option of selecting their preferred url.

@matthuisman
Copy link
Owner

matthuisman commented Apr 28, 2022 via email

@tinuva
Copy link
Author

tinuva commented Apr 28, 2022

Thanks for the info. Requesting every programs data for every channel must take awhile?

Initially 2h30m but went up to 5h after adding in a fix for some channels not displaying at all in Kodi.

I thought DStv would block something making that many quick requests

I would think they same, but if you view the https://github.com/iptv-org/egp repo they have been running it for a long time to both guides.dstv.com and dstv.com/en-za/discover/tv-guide/

Currently I only collect 2 days but it does update daily.

@matthuisman
Copy link
Owner

matthuisman commented Apr 28, 2022 via email

@tinuva
Copy link
Author

tinuva commented Apr 28, 2022

Currently it is all running in serial. First objective was to get it working 100% in kodi with the addon for me.

Happy to look at changing it to run concurrently as a future improvement. Code runs on nodejs so it should definitely be possible.

@matthuisman
Copy link
Owner

Also, if you know it takes 5 hours, then you could skip the first 5 hours of epg.
Or, retrieve 5x extra hours and use them instead.

Anyway, I'll try swap over the EPG source to your url tonight.

@tinuva
Copy link
Author

tinuva commented Apr 29, 2022

That is a good idea! I am going to try and improve the time regardless. The action is configured to timeout after 8 hours as a safety to prevent forever running.

Thank you for the update!

@tinuva
Copy link
Author

tinuva commented Apr 29, 2022

Actually this morning it was much quicker: (only 2h23m)
Screenshot 2022-04-29 at 06 56 30

Perhaps the 5 hour runs was something externally affecting the time.

@matthuisman
Copy link
Owner

is your guide ok? in chrome opening https://tinuva.github.io/epg/guides/za/dstv.com.epg.xml gives you "error on line 33 at column 42: xmlParseEntityRef: no name"

@matthuisman
Copy link
Owner

matthuisman commented Apr 29, 2022

ok, ive updated my server-side code to pull your epg every hour and serve that instead. this way dont need to change add-on and can switch easily if need to in future etc :) Thank you

@tinuva
Copy link
Author

tinuva commented Apr 30, 2022

is your guide ok? in chrome opening https://tinuva.github.io/epg/guides/za/dstv.com.epg.xml gives you "error on line 33 at column 42: xmlParseEntityRef: no name"

I think that is expected. The generator does add html entities, however when using in kodi, those html entities cause those channels to show up empty in kodi. When removing the html entities, this resolve the kodi display issue but then I guess makes the guide give that error in a browser. The aim was to have it work in kodi.

ok, ive updated my server-side code to pull your epg every hour and serve that instead. this way dont need to change add-on and can switch easily if need to in future etc :) Thank you

Awesome! Thank you!

@tinuva
Copy link
Author

tinuva commented Apr 30, 2022

Actually this issue also breaks it for kodi.

I am pushing an update to fix the xmlParseEntityRef error.

@matthuisman
Copy link
Owner

matthuisman commented Apr 30, 2022 via email

@matthuisman
Copy link
Owner

matthuisman commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants