Drop babel-runtime #140
Merged
Drop babel-runtime #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only being used to support async functions. Async is now supported in the stage-3 babel preset via transform-async-to-generator. - Drop stage-0 preset that is not needed - Drop transform-runtime plugin - Bring in regenerator-runtime to support async transform
dustinfarris
force-pushed
the
drop-babel-runtime
branch
from
7ba3dc1
to
5f4e6c8
Compare
|
testing now... |
|
after nuking all node_modules & running this via symlink, it seems to work beautifully, thank you! |
This was referenced Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async functions are supported by babel in the stage-3 preset via transform-async-to-generator.
regenerator-runtime is required to support the plugin (added to dependencies).
From docs on transform-regenerator:
Also swapped in stage-1 since we no longer need stage-0.
Closes #138