Updates on Expose syntax, docs updates, travis ci for current node versions and tests #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @matutter! Nice to meet you!
First of all: thanks! I really appreciate your effort on this repository, well done man! This small pack of yours really helped me with few daily builds with small dynamic parameter changes, you have no idea!
I'm here proposing just a small change, I hope we can have a small discussion on those items below:
file.expose()
method on current Dockerfile version does not accept the syntax with an array of ports. So for you to expose more than one at once it should look like:EXPOSE 80/tcp 443/tcp
; separated by space. Currently yours generatesEXPOSE [ 80/tcp, 443/tcp ]
and I keep gettingInvalid containerPort ]
. More at docs!file.user()
which is a huge deal for containers I use. And the best part: you have done that! Haha, why is it not there? 😄.travis.yml
Node's versions 8, 10;Thanks to you I can already see everything working well with the travis config you've done (https://travis-ci.org/drentrega/dockerfilejs/jobs/410836118).
Greetings from São Paulo!
Filipe