Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title graphics / section title line break #32

Merged
merged 2 commits into from
Feb 22, 2015
Merged

Conversation

benjamin-weiss
Copy link
Contributor

No description provided.

Benjamin Weiss added 2 commits February 20, 2015 23:12
I don’t like the manual linespacing fix. In my opinion
\textsc{\MakeLowercase{…}} should be replaced by \MakeUppercase{…} and
the fontsize adjusted accordingly.

2pt shift of the progress bar doesn’t make sense as I see it. I
therefore removed it.
@matze
Copy link
Owner

matze commented Feb 22, 2015

Many thanks for the changes and fixes. I couldn't chime in earlier about the title graphics issue but I agree with you that this makes more sense (albeit it's not really nice to look at).

By the way, thanks also for the HSRM theme which was a great initial example and motivation for this theme.

matze added a commit that referenced this pull request Feb 22, 2015
Title graphics / section title line break
@matze matze merged commit 32ce884 into matze:master Feb 22, 2015
@benjamin-weiss
Copy link
Contributor Author

Nothing to thank for. I really like what you did with your theme. Your more minimalistic approach is even better than my HSRM theme. And overall it is much more universal than my theme.

What do you think about the \textsc{\MakeLowercase{…}} problem. Why did you do that in the first place? (look at the comment @ benjamin-weiss@629c117)

@matze
Copy link
Owner

matze commented Feb 22, 2015

Using small caps of lower-cased letters looks a whole lot different than just uppercasing them. So I use that purely for aesthetic reasons.

@benjamin-weiss
Copy link
Contributor Author

Ok, I see. When there is a real small caps font style with the Fira font: why not just use small caps and drop the \MakeLowercase or \MakeUppercase? Have you tested that? How does it look like?

FYI, I just used the \MakeUppercase in my theme, because it was part of the Corporate Design. I don't really think this is good typesetting.

@matze
Copy link
Owner

matze commented Feb 23, 2015

why not just use small caps and drop the \MakeLowercase or \MakeUppercase?

Fira Sans has small caps for lower and uppercase letters which is maybe okay for single-world titles (see image) but looks a bit wonky for longer "camel-cased" sentences.

comparison

@matze matze mentioned this pull request Mar 18, 2015
@y1lan
Copy link

y1lan commented May 16, 2024

I would like to know that how can I use title graphics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants