Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section #9

Merged
merged 4 commits into from
Nov 13, 2011
Merged

Add section #9

merged 4 commits into from
Nov 13, 2011

Conversation

Uberi
Copy link
Contributor

@Uberi Uberi commented Nov 12, 2011

I couldn't figure out how to reopen it either :/.

Anyways, I added a section about using A_PtrSize to calculate offsets portably, and added a contributor entry.

@Uberi
Copy link
Contributor Author

Uberi commented Nov 12, 2011

Done.

@Uberi
Copy link
Contributor Author

Uberi commented Nov 12, 2011

Link added. Anything else?

@maul-esel
Copy link
Owner

  • Sentence 3 seems to be missing a verb.
  • not sure whether the struct definition should be highlighted?
  • the 1st line under "pointer types" has an unescaped * (escape with backslash)
  • It should be noted that A_PtrSize exists only in AutoHotkey_L**, AutoHotkey_H, AutoHotkey v2 and AutoHotkey_H v2**
    (or simply and newer).
  • same for UPtr and StrGet() / StrPut() + code examples
  • also unescaped: Arrays -> paragraph 1

@Uberi
Copy link
Contributor Author

Uberi commented Nov 12, 2011

Sentence 3 seems to be missing a verb.

It is, nice catch.

not sure whether the struct definition should be highlighted?

Probably not, considering that C++ code highlighting might confuse people who expect the sample to be AHK code. If you think there should be highlighting though, feel free to add it - I'm not sure how to have it highlight C++.

the 1st line under "pointer types" has an unescaped * (escape with backslash)

I've escaped it, as well as the other one under Arrays.

It should be noted that A_PtrSize exists only in AutoHotkey_L, AutoHotkey_H, AutoHotkey v2 and AutoHotkey_H v2 (or simply and newer).

I used "or similarly recent versions" to describe all these different version of AutoHotkey, since "and newer" implies hierarchy.

@maul-esel
Copy link
Owner

OK. Should I merge now?

@Uberi
Copy link
Contributor Author

Uberi commented Nov 13, 2011

If you don't see any other issues, that'd be great.

@maul-esel maul-esel merged commit 8e71774 into maul-esel:gh-pages Nov 13, 2011
@maul-esel
Copy link
Owner

Done. Thanks again!

@maul-esel
Copy link
Owner

While writing on the DllCall page it comes to my mind it might possibly be better to split the "type mapping" part and put it either on the DllCall page or in a separate page.

Also, what do you think of adding a more complex example? As I use MessageBox for DllCalls, I thought of MessageBoxIndirect.

@Uberi
Copy link
Contributor Author

Uberi commented Nov 24, 2011

While writing on the DllCall page it comes to my mind it might possibly be better to split the "type mapping" part and put it either on the DllCall page or in a separate page.

How about a page describing types in AHK, generally? Like Object/String/Integer/Float, and how these map to "machine" types?

Also, what do you think of adding a more complex example? As I use MessageBox for DllCalls, I thought of MessageBoxIndirect.

I believe MessageBoxIndirect is a function as well. I think you meant MSGBOXPARAMS. In any case, I'm a bit busy lately but that would be a great thing to have.

@maul-esel
Copy link
Owner

How about a page describing types in AHK, generally? Like Object/String/Integer/Float, and how these map to "machine" types?

+1. I probably would put this right before DllCalls.

1 similar comment
@maul-esel
Copy link
Owner

How about a page describing types in AHK, generally? Like Object/String/Integer/Float, and how these map to "machine" types?

+1. I probably would put this right before DllCalls.

maul-esel pushed a commit that referenced this pull request Nov 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants