Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoloading and formatting changes #4

Closed
wants to merge 2 commits into from
Closed

Autoloading and formatting changes #4

wants to merge 2 commits into from

Conversation

asimlqt
Copy link

@asimlqt asimlqt commented Jul 30, 2014

Hi,

I've recently started looking into Cassandra and came across your project but i had an issue with the autoloader not working so i fixed that and then started formatting the code as well.

Basically what I've done is fixed the autoloader and moved the code to be compliant with PSR-4 and formatted the code to follow the PSR-2 standard.

I've created a new namespace "Cql" as recommended by the PSR-4 standard and also this project (currently) only deals with the cql binary protocol i thought it makes sense. In future hopefully we can add other namespaces if we implement new features.

It may seem like every file has been modified but i've not touched any actual business logic (i dont know enough at this point to make any modifications). So your actual code is exactly as it was.

If you want you can merge my changes into the main branch, if not then i understand.

Perhaps you should look into using git tags, they work really well with composer and ideal for changes which break backwards compatibility.

Btw you've done some awesome work. It's the best php/cassandra cql implementation i've found.

Thanks
Asim

@asimlqt asimlqt closed this Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant