Skip to content

Conversation

maurogioberti
Copy link
Owner

@maurogioberti maurogioberti commented Aug 18, 2024

Description

This PR introduces several significant enhancements to the Integrity Assurance process within the project, focusing on Docker integration, new endpoint implementations, and improved testing strategies. The key changes include:

- Main changes include:
- Docker Integration for Integrity Assurance:
  - Implemented a Docker-based setup to ensure consistent and isolated environments for running Integrity Assurance tests.
  - Included a `docker-compose.yml` file for initializing a SQL Server container, which is now part of the Integrity Assurance initialization process.
  
- Database Seeding Enhancements:
  - Added SQL scripts for seeding test data during Integrity Assurance.
  - Ensured that the correct database context is used when running these scripts.

- New API Endpoints:
  - Implemented GET and DELETE endpoints in the TextController.
  - Added corresponding service and logic layers to handle data retrieval and deletion operations.

- Testing and Validation Improvements:
  - Added new integration tests (`GetTests`, `DeleteTests`) to validate the functionality of the GET and DELETE endpoints.
  - Introduced helper methods to streamline test assertions.
  
- Exception Handling Enhancements:
  - Improved exception handling in the service layer for handling missing records.
  - Ensured that the appropriate HTTP status codes are returned when exceptions are encountered.

Checklist

  • Code compiles without errors.
  • All tests pass.
  • Newly added functionality has been tested.
  • Changes do not introduce new warnings or errors.
  • Code follows the project's coding style.
  • PR is up-to-date with the main branch.

Testing Strategy

Integration Testing: The Docker-based setup was tested to ensure that the database initialization, migrations, and data seeding processes work correctly in an isolated environment.

Additional Notes

  • The Docker setup for Integrity Assurance is a significant addition that requires Docker to be installed and running on the host machine.
  • The new helper methods and exception handling improvements aim to enhance code readability and maintainability.
  • This PR is currently in draft mode, and further refinements may be needed based on initial feedback.

@maurogioberti maurogioberti changed the title Poc integrity assurance docker improvements Integrity assurance docker improvements Aug 18, 2024
@maurogioberti maurogioberti force-pushed the poc-integrity-assurance-docker-improvements branch from 82340d4 to 8dbe5f5 Compare August 29, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant