(#4794) Schedule and send reports #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxell92
added
feature
Maxell92
changed the title
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
from
39d50e3
to
9e35281
Compare
Maxell92
changed the title
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
3 times, most recently
from
5a38bb0
to
81a069a
Compare
Maxell92
added
ready-to-test
Maxell92
changed the title
alanhartless
suggested changes
Nov 6, 2017
alanhartless
suggested changes
Nov 6, 2017
app/bundles/ReportBundle/Scheduler/Command/ExportSchedulerCommand.php
Outdated
Show resolved
Hide resolved
escopecz
previously requested changes
Nov 9, 2017
escopecz
reviewed
Nov 9, 2017
| // this up() migration is auto-generated, please modify it to your needs | ||
| $this->abortIf($this->connection->getDatabasePlatform()->getName() != 'mysql', 'Migration can only be executed safely on \'mysql\'.'); | ||
|
|
||
| $this->addSql("ALTER TABLE {$this->prefix}reports ADD is_scheduled TINYINT(1) NOT NULL, ADD schedule_unit VARCHAR(255) DEFAULT NULL, ADD schedule_day VARCHAR(255) DEFAULT NULL, ADD schedule_month_frequency VARCHAR(255) DEFAULT NULL"); |
There was a problem hiding this comment.
@alanhartless didn't we agree that each migration should take care of only one column?
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
2 times, most recently
from
33bc09f
to
9e1a369
Compare
|
Is this ready to be tested? |
|
Yes it is.
On Wed, Nov 15, 2017 at 19:28, jimeno <notifications@github.com> wrote:
Is this ready to be tested?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [#5205 (comment)] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AAD3UPg1w51L7T9_cTcDYFL7BTnVjitZks5s24-5gaJpZM4QGIr7] .
|
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
3 times, most recently
from
b9a1077
to
68fdadf
Compare
|
Rebased - resolved conflicts. |
alanhartless
suggested changes
Nov 21, 2017
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
from
68fdadf
to
6a41a3b
Compare
alanhartless
previously approved these changes
Nov 21, 2017
Maxell92
force-pushed
the
feature/4794-report-schedule
branch
from
fb28c6c
to
e743619
Compare
|
Rebased on actual staging. |
|
Don't forget to regen prod assets if not in dev. |
|
+1 This is working great. Thanks @Maxell92! My only "complaint" is that in dev mode we get translation errors in the console when sending the report, but they are suppressed in prod env. |
dongilbert
approved these changes
Nov 21, 2017
|
Hello @Maxell92 there is nothing about it in the documentation and especially about the fact that the command Thanks a lot for your help ! |
|
Hello @npracht, yes, you are right. Thank you very much for your comment! I added documentation of this cron in this PR: mautic/documentation#268. |
|
thank a lot for your help ! i very appreciate !!! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds an ability to schedule reports and email them to a specified list of users.
Steps to test this PR:
composer installandapp/console d:m:m. Clear cache.Schedule.reports(scheduled fields should beNULL) +reports_schedulers(no records here yet).app/console mautic:reports:scheduler. There should be no error.week daysoption pls :)reports_schedulersholds only 1 date of next schedule event. Do this with as much combination as possible.tofield and save a report. Make sure you have configured sending emails from your Mautic instance.reports_schedulerstable and edit date of scheduler - set it to some past date.app/console mautic:reports:schedulerand you should get an email with report. Check the attachment that results match report data.report_export_max_filesize_in_bytesinapp/ReportBundle/Config/config.phpto have bigger file size than in settings. Set correct date inreports_schedulerstable and send the report. You should get an email with no attached file and link to the report detail.List deprecations along with the new alternative:
List backwards compatibility breaks: